FindBugs Report

Produced using FindBugs3.0.1.

Project:

Metrics

189 lines of code analyzed, in 5 classes, in 1 packages.

Metric Total Density*
High Priority Warnings NaN
Medium Priority Warnings NaN
Low Priority Warnings 1 5.29
Total Warnings 1 5.29

(* Defects per Thousand lines of non-commenting source statements)



Summary

Warning Type Number
Performance Warnings 1
Total 1



Warnings

Click on each warning link to see a full description of the issue, and details of how to resolve it.

Performance Warnings

Warning Priority Details
Could be refactored into a static inner class Low

The class groovyx.net.http.OkHttpBuilder$OkHttpFromServer could be refactored into a _static_ inner class


In file OkHttpBuilder.java, lines 266 to 321
In class groovyx.net.http.OkHttpBuilder$OkHttpFromServer
At OkHttpBuilder.java:[lines 266-321]





Warning Types

Could be refactored into a static inner class

This class is an inner class, but does not use its embedded reference to the object which created it except during construction of the inner object.  This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary.  If possible, the class should be made into a static inner class. Since the reference to the outer object is required during construction of the inner instance, the inner class will need to be refactored so as to pass a reference to the outer instance to the constructor for the inner class.